Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dy2St] pir dy2st unittest verification - Part 12 #59378

Merged
merged 22 commits into from
Dec 6, 2023

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Nov 26, 2023

PR types

Others

PR changes

Others

Description

状态 单测 错误类别 备注 报错信息
test_yolov3 API(疑似) 首次 Upsample 里 interpolate shape 为 [0],但单独无法复现,可能是前面的问题,已反馈震哥 #59550 已修
test_yolov3 API 含 BN 单测会报 CUDA 700,待相关问题修复后复测
test_place #58042 适配过啦
🟡 test_declarative: test_with_input_spec API 需要适配jit.api.save方法
test_declarative: TestInputSpec.test_concrete_program 改好了 API OpResult.shape的返回是list,而legacy ir下的是tuple, 解决完后还有name属性调用的问题 ValueError: (InvalidArgument) Currently, we can only get name of OpResult that is persistable
test_declarative: TestInputDefaultName 动转静组网 attr没有被设置上 AssertionError: Lists differ: [] != ['x']
test_declarative: TestDeclarativeAPI ? 切换问题或者单测写法问题, 可以测试单一ir模式 AssertionError: We only support 'to_variable()' in dynamic graph mode, please call 'paddle.disable_static()' to enter dynamic graph mode.
test_declarative: TestDecorateModelDirectly ? 好像跟attr是一样的问题 self.assertTrue(len(net.forward.inputs) == 1) AssertionError: False is not true
test_declarative: test_set_buffers1 API name属性调用的问题,jit.api.save问题,还有setitem问题
test_declarative: test_set_buffers2 API setitem暂不支持 应该要报错(类似):RuntimeError: In Dy2stat, self.b is a buffer and self.b is not allowed to be set to Variable when self.b is None.
🟡 test_fallback: {test_case_func_fallback, test_case_net_fallback, test_case_net_error, test_case_training, test_case_save_error_2} CINN CINN暂不支持 NotImplementedError: (Unimplemented) Currently we only support CINN Pass for Pir under @to_static, please compile PaddlePaddle with CINN
test_fallback: test_case_flag 单测 需要补充单测
test_convert_operators: test_variable API OpResult 不支持 __eq__ ValueError: (InvalidArgument) all(): argument (position 1) must be OpResult, but got bool
test_tensor_memcpy_on_cpu API #59300 合入依赖已解
test_tensor_memcpy_on_cpu 动转静执行 set_parameter 会导致插入 D2H copy 回 CPU
test_tensor_memcpy_on_gpu API #59300 合入依赖已解

相关链接:

Copy link

paddle-bot bot commented Nov 26, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 26, 2023
@gouzil gouzil requested a review from SigureMo November 27, 2023 00:46
gouzil and others added 5 commits November 27, 2023 21:38
…_push_12

# Conflicts:
#	test/dygraph_to_static/test_convert_operators.py
#	test/dygraph_to_static/test_declarative.py
#	test/dygraph_to_static/test_fallback.py
#	test/dygraph_to_static/test_place.py
#	test/dygraph_to_static/test_yolov3.py
@@ -34,7 +34,7 @@ def test_place(self):
self.assertTrue(len(w) == 1)
if paddle.framework.use_pir_api():
self.assertTrue(
"OpResult do not have 'place'" in str(w[-1].message)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改成 assertIn 吧

@SigureMo SigureMo force-pushed the dy2st_pir_api_push_12 branch from 54c07ff to 33498cd Compare December 5, 2023 09:05
Copy link
Contributor

@zhangbo9674 zhangbo9674 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gouzil gouzil merged commit c7b5e0e into PaddlePaddle:develop Dec 6, 2023
28 checks passed
@gouzil gouzil deleted the dy2st_pir_api_push_12 branch December 27, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants